Repository navigation
ci: hold the container to a memory budget - #23
Merged
Merged
Conversation
The smoke test now runs the container with a 512 MB limit. A proxy that needs more is killed by the kernel, and the health check fails — the budget is enforced instead of parsed. The test also fails when the container writes anything to stdout, which keeps the "no log files" promise honest in the image itself.
The `/session` route is project-scoped, so the directory has to be passed. Without it the answer belongs to another project, and right after an abort it came back empty — which failed the test on a loaded runner. An empty body now counts as no sessions, and the wait tolerates a server that is busy rebuilding its instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke test now runs the container with a 512 MB limit. A proxy that needs more is killed by the kernel, and the health check fails — the budget is enforced instead of parsed.
The test also fails when the container writes anything to stdout, which keeps the "no log files" promise honest in the image itself.