Repository navigation
CLI-015: Keep tabs and separator characters from reshaping the terminal cards - #735
Open
shanedasbach wants to merge 3 commits into
Open
shanedasbach wants to merge 3 commits into
shanedasbach wants to merge 3 commits into
Conversation
…al cards Card fields expand tabs to spaces instead of deleting them, and bodies and flag diffs split only at real line ends, so form feeds, NEL and the Unicode separators never start a new line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rm74zQcmssF7TxiN7ZceZY
…Unicode separators on cards only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rm74zQcmssF7TxiN7ZceZY
…abs-and-separators-on-cards # Conflicts: # docs/backlog/INDEX.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The terminal cards deleted tabs (
four<tab>tabprintedfourtab), and bodies split on\x0b,\x0c,\x1c-\x1e,\x85, U+2028 and U+2029 because ofstr.splitlines. The flag diff split the same way (CLI-015).Changes
lore/ui.py:cleanexpands tabs before removing controls, and U+2028/U+2029 are removed too. Card bodies split withtext_lines.lore/store.py: newtext_lines(), splitting at\n,\r\nand a lone\ronly.flag_detaildiffs with it.CardShapeTestintests/test_ui.pyand a flag-diff split test intests/test_store.py.Test plan
a\rbisabin a title and two lines in a body\x85diffs as one changed linetests/gate.py --python-only(1263 passed; ui.py 100%)🤖 Generated with Claude Code
https://claude.ai/code/session_01Rm74zQcmssF7TxiN7ZceZY